On Fri, Oct 28, 2016 at 09:53:38AM -0700, Tony Lindgren wrote:

* Tony Lindgren [off-list ref] [161027 07:59]:

quoted

* Linus Walleij [off-list ref] [161027 00:57]:

quoted

On Tue, Oct 25, 2016 at 6:45 PM, Tony Lindgren [off-list ref] wrote:

quoted

+/*
+ * For pinctrl binding, typically #pinctrl-cells is for the pin controller
+ * device, so either parent or grandparent. See pinctrl-bindings.txt.
+ */
+static int pinctrl_find_cells_size(const struct device_node *np,
+                                  const char *cells_name)
+{
+       int cells_size, error;
+
+       error = of_property_read_u32(np->parent, cells_name, &cells_size);
+       if (error) {
+               error = of_property_read_u32(np->parent->parent,
+                                            cells_name, &cells_size);
+               if (error)
+                       return -ENOENT;
+       }
+
+       return cells_size;
+}

Can't we just hardcode this to "#pinctrl-cells" and skip the cells_name
parameter? We can parametrize it the day we need it instead.

Sure we can do that.

quoted

The rest of the helpers look nice and clean.

OK cool thanks,

Below is an updated version of this patch with documentation updated
and cells_name removed. I'll repost the whole series once the DT
binding has been reviewed.

Regards,

Tony
8< -------------------------
From tony Mon Sep 17 00:00:00 2001
From: Tony Lindgren <redacted>
Date: Tue, 25 Oct 2016 08:33:34 -0700
Subject: [PATCH] pinctrl: Introduce generic #pinctrl-cells and
 pinctrl_parse_index_with_args

Introduce #pinctrl-cells helper binding and generic helper functions
pinctrl_count_index_with_args() and pinctrl_parse_index_with_args().

Signed-off-by: Tony Lindgren <redacted>
---
 .../bindings/pinctrl/pinctrl-bindings.txt          |  44 ++++++-

Acked-by: Rob Herring <redacted>

 drivers/pinctrl/devicetree.c                       | 144 +++++++++++++++++++++
 drivers/pinctrl/devicetree.h                       |  21 +++
 3 files changed, 208 insertions(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html