Re: [PATCH V2] pinctrl: qcom: Add msm8994 pinctrl driver
From: Bjorn Andersson <hidden>
Date: 2016-10-29 18:07:05
Also in:
linux-arm-msm, linux-gpio, lkml
From: Bjorn Andersson <hidden>
Date: 2016-10-29 18:07:05
Also in:
linux-arm-msm, linux-gpio, lkml
On Wed 26 Oct 16:32 PDT 2016, Michael Scott wrote:
Initial pinctrl driver for QCOM msm8994 platforms. In order to continue the initial board support for QCOM msm8994/msm8992 presented in patches from Jeremy McNicoll [off-list ref], let's put a proper pinctrl driver in place. Currently, the DT for these platforms uses the msm8x74 pinctrl driver to enable basic UART. Beyond the first few pins the rest are different enough to justify it's own driver. Note: This driver is also be used by QCOM's msm8992 platform as it's TLM block is the same.
I'm not up to speed on the 8992/8994 story, but please add a "qcom,msm8992-pinctrl" compatible to the list as well.
- Initial formatting and style was taken from the msm8x74 pinctrl driver added by Björn Andersson [off-list ref] - Data was then adjusted per QCOM MSM8994 documentation for Top Level Multiplexing
I think this is good enough. It looks reasonable and you based it on the data sheet. Any fixes to the tables can be added incrementally.
- Bindings documentation was based on qcom,msm8996-pinctrl.txt by Joonwoo Park [off-list ref] and then modified for msm8994 content Signed-off-by: Michael Scott <redacted>
Please add the compatible and you have my Acked-by: Bjorn Andersson <redacted> Regards, Bjorn