Thread (5 messages) 5 messages, 4 authors, 2016-10-27

Re: [PATCH] i2c: rk3x: Give the tuning value 0 during rk3x_i2c_v0_calc_timings

From: Wolfram Sang <hidden>
Date: 2016-10-27 14:02:14
Also in: linux-arm-kernel, linux-i2c, linux-rockchip, lkml

On Sat, Oct 22, 2016 at 04:43:42PM +0800, David Wu wrote:
We found a bug that i2c transfer sometimes failed on 3066a board with
stabel-4.8, the con register would be updated by uninitialized tuning
value, it made the i2c transfer failed.

So give the tuning value to be zero during rk3x_i2c_v0_calc_timings.

Signed-off-by: David Wu <redacted>
What I missed to say in my review:

Please use a subject line that describes WHY the change is needed not so
much WHAT is done. Like: "fix missing initialization causing boot
problems"
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help