Thread (7 messages) 7 messages, 3 authors, 2016-10-25

Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection

From: Tony Lindgren <hidden>
Date: 2016-10-25 17:34:18
Also in: linux-omap, lkml

* H. Nikolaus Schaller [off-list ref] [161025 10:20]:
quoted
Am 25.10.2016 um 18:51 schrieb Peter Ujfalusi [off-list ref]:

On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote:
quoted
Signed-off-by: H. Nikolaus Schaller <redacted>
---
arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
index b04adee..91456b4 100644
--- a/arch/arm/boot/dts/omap5-board-common.dtsi
+++ b/arch/arm/boot/dts/omap5-board-common.dtsi
@@ -124,6 +124,7 @@
		compatible = "ti,abe-twl6040";
		ti,model = "omap5-uevm";

+		ti,jack_detection;
ti,jack-detection
Hm. Looks as if we have found another bug:
which one is correct?

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt#n15

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/omap-abe-twl6040.c#n289

Should I add another patch?
We have parts of omap-abe-twl6040.txt, the driver and omap4-sdp.dts all
using ti,jack-detection. So omap-abe-twl6040.txt is wrong for the use
of ti,jack_detection.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help