Re: [PATCH v3] pinctrl: Add SX150X GPIO Extender Pinctrl Driver
From: Linus Walleij <hidden>
Date: 2016-10-24 14:39:22
Also in:
linux-gpio, lkml
From: Linus Walleij <hidden>
Date: 2016-10-24 14:39:22
Also in:
linux-gpio, lkml
On Mon, Oct 24, 2016 at 6:51 AM, Andrey Smirnov [off-list ref] wrote:
It seem strange to me that the driver uses "handle_edge_irq", given how none of the individual interrupts seem to require any ACKing, since it is all handled in sx150x_irq_thread_fn(), line 533. More so, I had trouble finding who/where sets .irq_ack() callback, which AFAIU is mandatory for handle_edge_irq().
Yes that looks strange. Neil have you tested IRQs with this code? If there is trouble, please follow up with a fix for the edge handler. Maybe it should just be handle_simple_irq(). Yours, Linus Walleij