On Fri, Oct 21, 2016 at 7:37 PM, Sinan Kaya [off-list ref] wrote:

The interrupts can now be delivered as platform MSI interrupts on newer
platforms. The code looks for a new OF and ACPI strings in order to enable
the functionality.

+#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
+static void hidma_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)
+{
+       struct device *dev = msi_desc_to_dev(desc);
+       struct hidma_dev *dmadev = dev_get_drvdata(dev);
+
+       if (!desc->platform.msi_index) {
+               writel(msg->address_lo, dmadev->dev_evca + 0x118);
+               writel(msg->address_hi, dmadev->dev_evca + 0x11C);
+               writel(msg->data, dmadev->dev_evca + 0x120);
+       }
+}
+#endif
+
+static void hidma_free_msis(struct hidma_dev *dmadev)
+{
+#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN

Perhaps one #ifdef and two definitions of functions?

-- 
With Best Regards,
Andy Shevchenko