Re: [PATCH 3/6] gpio: gpio-cbc: Document bindings of CBC FPGA GPIO block
From: Linus Walleij <hidden>
Date: 2016-10-21 08:45:26
Also in:
linux-gpio, lkml
On Fri, Oct 7, 2016 at 5:20 PM, Pantelis Antoniou [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Georgi Vlaev <redacted> Add device tree bindings document for the GPIO driver of Juniper's CBC FPGA. Signed-off-by: Georgi Vlaev <redacted> [Ported from Juniper kernel] Signed-off-by: Pantelis Antoniou <redacted> --- .../devicetree/bindings/gpio/jnx,gpio-cbc.txt | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txtdiff --git a/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt b/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt new file mode 100644 index 0000000..d205d0b --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/jnx,gpio-cbc.txt@@ -0,0 +1,30 @@ +Juniper CBC FPGA GPIO block + +Required properties: + +- compatible: + Must be "jnx,cbc-gpio" + +Optional properties: + +- reg: + Address and length of the register set for the device. This is optional since + usually the parent MFD driver fills it in. + +- #gpio-cells: + Should be <2>. The first cell is the pin number (within the controller's + pin space), and the second is used for the following flags: + bit[0]: direction (0 = out, 1 = in) + bit[1]: init high + bit[2]: active low
Can't you just refer to the generic bindings? Apart from that it looks fine. Yours, Linus Walleij