On Wed, Oct 5, 2016 at 7:23 AM, Nava kishore Manne
[off-list ref] wrote:

Hi Rob,

        Thanks for the review...

quoted

quoted

Changes for v5:
            -Fixed some minor comments.

Not a useful changelog. The point of these comments is to remind the
reviewers of what they commented on.

Ok will take care from next version onwards...

quoted

quoted

 Required properties:
-- compatible : should be "cdns,uart-r1p8", or "xlnx,xuartps"
+- compatible :
+  Use "cdns,uart-r1p8", or "xlnx,xuartps" for Zynq-7xxx SoC.

This is still not right. It was wrong before, but you are touching it so make it
right.

OR doesn't match the dts files. It is AND and the opposite order.

xlnx,xuartps wasn't the best naming, but it's in use so we'll have to live with it
for zynq-7xxx.

quoted

+  Use "cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC.

What I meant here was this should have something like "xlnx,mpsoc-uart"
as the first compatible with "cdns,uart-r1p12" as the second. Not sure if
"mpsoc" is the best name here.

You mean something like below
 Use "xlnx,xuartps" or "cdns,uart-r1p8" for Zynq-7xxx SoC.

As I said, it is not an OR condition. 'Use "xlnx,xuartps",
"cdns,uart-r1p8" for Zynq-7xxx SoC

Use "xlnx,zynqmp-uart" or " cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC.

Yes, but as above.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html