Re: [PATCH] ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes
From: Kevin Hilman <hidden>
Date: 2016-09-30 15:49:27
Also in:
linux-amlogic, linux-arm-kernel
Brian Kim [off-list ref] writes:
Enable both gxbb USB controller and add a 5V regulator for the OTG port VBUS Signed-off-by: Brian Kim <redacted>
Thanks for the patch. In the future, please state what branch the patch should apply to when not using mainline. Because of the sd_emmc nodes in your patch, I could tell that it was based on my integ branch so was able to figure it out, but it's very helpful to maintainers if you state the branch and/or any dependencies explicity.
quoted hunk
--- .../arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+)diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts index 8d89edc..997c671 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts@@ -64,6 +64,18 @@ reg = <0x0 0x0 0x0 0x80000000>; }; + usb_pwr: regulator-usb-pwrs {
minor nit: since this is specific to the OTG part, can you call this usb_otg_pwr? ...
quoted hunk
+ compatible = "regulator-fixed"; + + regulator-name = "USB_PWR";
... and rename this also?
quoted hunk
+ regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + + gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; +
Thanks Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html