Re: [v2] rt2x00: add support for mac addr from device tree
From: Kalle Valo <hidden>
Date: 2016-09-28 10:55:38
Also in:
linux-wireless
Mathias Kresin [off-list ref] writes:
2016-09-27 17:50 GMT+02:00 Kalle Valo [off-list ref]:quoted
Mathias Kresin [off-list ref] wrote:quoted
On some devices the EEPROMs of Ralink Wi-Fi chips have a default Ralink MAC address set (RT3062F: 00:0C:43:30:62:00, RT3060F: 00:0C:43:30:60:00). Using multiple of these devices in the same network can cause nasty issues. Allow to override the MAC in the EEPROM with (a known good) one set in the device tree to bypass the issue. Signed-off-by: Mathias Kresin <redacted> Acked-by: Stanislaw Gruszka <redacted>I think this needs to update the devicetree binding document. Also remember to CC the devicetree mailing list. Patch set to Changes Requested. -- https://patchwork.kernel.org/patch/9300893/Hey Kalle, was it intentional not to CC the linux-wireless list?
No, that was a bug in my script. Thanks for noticing it! Please always report back if my script does something strange. I'm adding now linux-wireless back.
I thought about _adding_ a devicetree binding document before sending the patch. But in the end it would be an empty file, since I neither add any bindings nor introduce a compatible string. I'm just add support for the generic of_get_mac_address() devicetree property, which is meant to be used via a devicetree pci childnode. I grepped though the 4.7 code and found a few driver using of_get_mac_address() without having a devicetree binding document: - drivers/net/usb/smsc95xx.c - drivers/net/usb/smsc75xx.c - drivers/net/ethernet/marvell/sky2.c - drivers/net/ethernet/cavium/thunder/thunder_bgx.c - drivers/net/ethernet/wiznet/w5100-spi.c - drivers/net/ethernet/arc/emac_main.c Just let me know if you are still the opinion that a devicetree binding document is required to get this patch accepted.
I'm not familiar enough device tree to really comment. Can someone from the device tree list (CCed) help? Full patch here: https://patchwork.kernel.org/patch/9300893/ -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html