Re: [PATCH V5 2/6] thermal: bcm2835: add thermal driver for bcm2835 soc

Hi Stefan!

On 18.09.2016, at 13:31, Stefan Wahren [off-list ref] wrote:

quoted

+	rate = clk_get_rate(data->clk);
+	if ((rate < 1920000) || (rate > 5000000)) {
+		dev_warn(&pdev->dev,
+			 "Clock %pCn is running at %pCr Hz, which is outside the recommended range
of 1.9 to 5.0 MHz\n",
+			 data->clk, data->clk);

Instead of printing the clock name twice your intension would be to print the
actual clock rate?

%pCn (and %pC) prints the clock name
%pCr prints the clock rate - I guess I could use “%lu” and rate instead

So I do not see an issue here - I will reword the text to shorten it.

Everything else I will fix as mentioned.

Martin--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html