Re: [PATCH v2 5/6] ARM64: meson-gxbb-p20x: Enable USB Nodes
From: Kevin Hilman <khilman@baylibre.com>
Date: 2016-09-14 18:05:17
Also in:
linux-amlogic, linux-arm-kernel, linux-clk
Martin Blumenstingl [off-list ref] writes:
From: Jerome Brunet <jbrunet@baylibre.com> Enable both gxbb USB controller and add a 5V regulator for the OTG port VBUS Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
nit: subject should have "ARM64: dts:" prefix.
quoted hunk
--- arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 29 ++++++++++++++++++++++++ 1 file changed, 29 insertions(+)diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi index ce105fe..4493bce 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi@@ -93,6 +93,18 @@ compatible = "mmc-pwrseq-emmc"; reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; }; + + usb_vbus: regulator-usb0-vbus {
nit: I like to use the signal name from the schematics for the node name (and for regulator-name below). In the schematics, that signal is named USB_PWR.
+ compatible = "regulator-fixed"; + + regulator-name = "USB0_VBUS"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + + gpio = <&gpio GPIODV_24 GPIO_ACTIVE_HIGH>;
Please add a comment above this line with the schematic signal name: USB_PWR_EN.
+ enable-active-high; + }; };
Kevin