Re: [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
From: Stefan Wahren <hidden>
Date: 2016-09-07 12:02:14
Also in:
linux-arm-kernel
Hi Gerd, Am 07.09.2016 um 12:59 schrieb Gerd Hoffmann:
On Mi, 2016-08-31 at 09:59 +0200, Stefan Wahren wrote:quoted
Hi Gerd, Am 21.08.2016 um 17:10 schrieb Stefan Wahren:quoted
In case dr_mode isn't passed via DT, the dwc2 driver defaults to OTG mode. But the Raspberry Pi 3 is designed only for host mode. So fix this issue by linking to the dtsi file which set the dr_mode to host.this patch is pending and the rest has been merged. Since i don't have a RPi 3 it's only compile tested. Could you please test it (requires patch 1 and 2 of this series) on your RPi 3?Have a git tree to test? Patch doesn't apply cleanly (using 4.8-rc5 with eric's for-next branch which already has 1+2), seems to depend on more device tree changes.
as i wrote in the changelog the patch series based on Ian Campbell's patches ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm Unfortunately i don't have a repo well prepared with this patch series. My development repo doesn't contain the final series V3 [1], but the master already has the necessary DT patches above.
Also usb is working fine for me on the rpi3 even without this, so why is this needed?
In case of a multiplatform config with following settings the driver isn't able to "detect" the role: CONFIG_USB=y CONFIG_USB_OTG=y CONFIG_USB_DWC2=y CONFIG_USB_DWC2_DUAL_ROLE=y CONFIG_USB_PHY=y CONFIG_NOP_USB_XCEIV=y CONFIG_USB_GADGET=y CONFIG_USB_ZERO=y Also please refer to my answer here [2] and this bug [3].
Is dwc2 defaulting to otg mode a recent change?
No, it's a default for all OTG host controller in case no dr_mode is defined. Regards Stefan [1] - https://github.com/lategoodbye/rpi-zero [2] - http://lists.infradead.org/pipermail/linux-rpi-kernel/2016-August/004242.html [3] - http://marc.info/?l=linux-usb&m=147169822213074&w=2
cheers, Gerd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html