Re: [PATCH] iio: sx9500: add final devicetree support

On Fri, 2016-09-02 at 13:16 -0300, Fabio Estevam wrote:

On Fri, Sep 2, 2016 at 12:23 PM, Christoph Fritz
[off-list ref] wrote:

quoted

What do you mean by "software command", to send a reset command by i2c?

Yes, by writing 0xDE into RegReset register.

quoted

The reset GPIO is fetched in sx9500 here:

See sx9500_gpio_probe():
...
        data->gpiod_rst = devm_gpiod_get_index(dev, SX9500_GPIO_RESET,
                                               0, GPIOD_OUT_HIGH);

but there is no code that actually reads the "reset-gpios" dt property.

But there is: devm_gpiod_get_index() calls gpiod_get_index() which calls
of_find_gpio() for of-string "reset-gpios".

Does your board work well without passing "reset-gpios" property?

I don't know, the driver looks that way. I'll check that. If so, I'll
fix the docu and add the reset-gpios property as optional. Okay?

Thanks
 -- Christoph