Resending with the right CC chain.

Le mercredi 21 septembre 2016 à 10:06 +0100, Jon Hunter a écrit :

On 21/09/16 09:26, Paul Kocialkowski wrote:

quoted

* PGP Signed by an unknown key

Le mercredi 21 septembre 2016 à 08:52 +0100, Jon Hunter a écrit :

quoted

On 20/09/16 19:14, Paul Kocialkowski wrote:

quoted

quoted

Old Signed by an unknown key

Le mardi 20 septembre 2016 à 18:15 +0100, Jon Hunter a écrit :

quoted

On 28/08/16 18:32, Paul Kocialkowski wrote:

quoted

This switches a few interrupt definitions that were using
GPIO_ACTIVE_HIGH as IRQ type, which is invalid.

May be you are right, but this does not describe why this is invalid.
Can you elaborate?

GPIO_ACTIVE_HIGH is simply not the right kind of define to use in the
"interrupts" devicetree property. Values provided there are understood
as
IRQ_TYPE_ defines.

Right, but you are changing the type as GPIO_ACTIVE_HIGH = 0 and
IRQ_TYPE_EDGE_FALLING = 2 and there is no comment about why this has
been changed. It might be correct, but you need to explain it.

This actually makes the IRQ trigger values consistent with the drivers, that
define them regardless of devicetree anyway. The max98090 driver
has IRQF_TRIGGER_FALLING and bq24735 has IRQF_TRIGGER_RISING |
IRQF_TRIGGER_FALLING.

This is really more of a cosmetic change, it doesn't impact actual use.

So you are saying that the drivers don't actually use the DT types?

It appears so. At least they are hardcoded in the kernel driver.

 May be that is ok, and yes this is cosmetic, but this should be stated in
the changelog as it is not clear what is going on here.

Fair enough, will do in v2.

-- 
Paul Kocialkowski, developer of low-level free software for embedded devices

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/