Thread (13 messages) 13 messages, 4 authors, 2016-10-25

Re: [PATCH v2 09/14] MIPS: Malta: Probe RTC via DT

From: Paul Burton <hidden>
Date: 2016-09-20 10:34:54
Also in: linux-mips, lkml

On 20/09/16 11:21, Sergei Shtylyov wrote:
Hello.

On 9/20/2016 12:21 AM, Paul Burton wrote:
quoted
Add the DT node required to probe the RTC, and remove the platform code
that was previously doing it.

Signed-off-by: Paul Burton <redacted>

---

Changes in v2:
- Remove rtc DT node label
   Haven't you also renamed the node?
Hi Sergei,

Yes, strictly speaking I could have been more verbose & elaborated in
the changelog on every aspect of the simple change from "rtc:
mc146818@70" to "rtc@70". I didn't, but as it's obviously clear to you
what changed and it has no effect on either the code or the commit that
would end up in git I don't really see the point of your bringing it up.

Thanks,
    Paul
quoted
 arch/mips/boot/dts/mti/malta.dts     | 15 +++++++++++++++
 arch/mips/mti-malta/malta-platform.c | 21 ---------------------
 2 files changed, 15 insertions(+), 21 deletions(-)
diff --git a/arch/mips/boot/dts/mti/malta.dts
b/arch/mips/boot/dts/mti/malta.dts
index af765af..fecbca8 100644
--- a/arch/mips/boot/dts/mti/malta.dts
+++ b/arch/mips/boot/dts/mti/malta.dts
@@ -49,4 +49,19 @@
         interrupt-parent = <&gic>;
         interrupts = <GIC_SHARED 3 IRQ_TYPE_LEVEL_HIGH>;
     };
+
+    isa {
+        compatible = "isa";
+        #address-cells = <2>;
+        #size-cells = <1>;
+        ranges = <1 0 0 0x1000>;
+
+        rtc@70 {
+            compatible = "motorola,mc146818";
+            reg = <1 0x70 0x8>;
+
+            interrupt-parent = <&i8259>;
+            interrupts = <8>;
+        };
+    };
 };
[...]

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help