Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac
From: Andrew Lunn <andrew@lunn.ch>
Date: 2016-09-12 15:15:39
Also in:
linux-arm-kernel, lkml, netdev
Hello
Since the MDIO bus is a part of the sun8i-emac, does I really need to create such a mdio node ?
It is good practice. Part of the issue is that there are no written guidelines, so different drivers do different things. I'm trying to push all new drivers to have an MDIO node.
Anyway I try the following patch to solve your comments, but it breaks the PHY finding(Could not attach to PHY).
quoted hunk ↗ jump to hunk
--- a/drivers/net/ethernet/allwinner/sun8i-emac.c +++ b/drivers/net/ethernet/allwinner/sun8i-emac.c@@ -2122,7 +2122,7 @@ static int sun8i_emac_probe(struct platform_device *pdev) return -EINVAL; } - priv->phy_node = of_parse_phandle(node, "phy", 0); + priv->phy_node = of_parse_phandle(node, "phy-handle", 0); if (!priv->phy_node) { netdev_err(ndev, "No associated PHY\n"); return -ENODEV; &crypto {
I don't see a change here for of_mdiobus_register(). You need to pass
the mdio node.
Andrew