On Tue, Sep 06, 2016 at 10:52:02AM +0200, Jorik Jonker wrote:

On Tue, Sep 06, 2016 at 11:04:38AM +0800, Chen-Yu Tsai wrote:

quoted

In short, I'm ok with it. But please put an explicit

  status = "disabled";

and probably a comment about how/where the peripheral can be
used in the board dts.

Allright, I will do that in v3.

quoted

I intended to do this for the Banana Pis. Though my original plan
was to enable Raspberry Pi compatible peripherals by default, and
list the other peripherals that are defined by the vendor as
"disabled".

"Defined by the vendor" means that the vendor has some sort of
document associating the gpio header pins with the peripherals,
as shown in:

  http://www.orangepi.org/Docs/Pindefinition.html#CON3_Definition

This should make it easier for the average user to enable the
peripherals. I'm not sure we should list _all_ possible ones
though. That would make the list very large, and some might
end up never being used.

This is exactly what I was thinking, albeit I wanted to go a bit 'bigger':
move all unambiguous pinmux/peripheral associations from the H3 DTS files to
the DTSI, complete them with known associations for which there are drivers,
and have all of these disabled. Reduce the existing blocks in the DTS files
to just "status = okay".

Peripherals requiring board-specific things (like emac, USB, voltage
regulators, displays) stay put in the DTS.

It will explodes the scope of my proposed change a bit, but if you are OK
with this, I will gladly do it.

Maxime, Chen-Yu: what do you think of this?

I'm not exactly sure what you have in mind. Please send a patch, and
we'll see then :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com