Re: [PATCH v8 15/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes

On Mon, 05 Sep 2016, Arnaud Pouliquen wrote:

quoted

quoted

quoted

quoted

+			dai-name = "Uni Reader #0 (PCM IN)";

Oooo, not seen something like this before.

If it does not already have one, it would require a DT Ack.

No idea, the driver got merged 1 year ago.

This field could be suppressed and handled in source code, using
st,uniperiph-id to retreive it.

That would be better.

quoted

quoted

Arnaud did you get a DT ack when you merged this driver & binding? i if i remember well, i had  sent to Alsa mailing list only, I missed

this obvious...

I'm surprised Mark didn't notice this.

He's usually pretty good at picking stuff like that up.

quoted

quoted

quoted

quoted

+			st,version = <3>;

This will likely need a DT Ack too.  We usually encode this sort of
information in the compatible string.

yes, better to use compatibility

quoted

quoted

See 05c1b4480e86a871b18030d6f3d532dc0ecdf38c

Well Rob's the boss.  We certainly never used to take 'device ID' or
'version' attributes.  I guess something must have changed.

I will try to provide patches for code and bindings rework this week.

Wonderful.. Thanks Arnaud.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html