Re: Documentation: tpm: Adds the TPM device tree node documentation
From: Wolfram Sang <hidden>
Date: 2016-08-30 20:51:56
Also in:
linux-i2c
Attachments
- signature.asc [application/pgp-signature] 819 bytes
From: Wolfram Sang <hidden>
Date: 2016-08-30 20:51:56
Also in:
linux-i2c
On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote:
This is documenting device tree binding for I2C based TPM, similar concept which being used for virtual TPM on POWER7 and POWER8 systems running PowerVM. Signed-off-by: Nayna Jain <redacted> --- Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29 +++++++++++++++++++++++
Is the driver in 'drivers/i2c/*'? No, so the binding shouldn't be in i2c as well.
+- compatible : 'manufacturer,model'
You need to specify them here!
+Optional properties: + +- status: indicates whether the device is enabled or disabled. "okay" for + enabled and "disabled" for disabled.
Optional? Rather "implicit" I'd say. This is far from ready. You should really wait for Rob's review. Or better: Have a look at other bindings.