Re: [PATCH V8 2/2] mmc: OCTEON: Add host driver for OCTEON MMC controller.
From: David Daney <hidden>
Date: 2016-08-23 19:59:35
Also in:
linux-mips, linux-mmc
On 08/23/2016 12:46 PM, Ulf Hansson wrote:
On 23 August 2016 at 19:41, David Daney [off-list ref] wrote:quoted
On 08/23/2016 07:53 AM, Ulf Hansson wrote:quoted
On 12 July 2016 at 20:18, Steven J. Hill [off-list ref] wrote:[...]quoted
quoted
+#include <asm/byteorder.h> +#include <asm/octeon/octeon.h>OK, we will duplicate any needed definitions from octeon.h into the driver source file.Why can't you share it via a platfrom data header at include/linux/platform_data/* ?
It isn't "platform_data", it is register layout definitions (thousands of lines of them), so I don't think it it appropriate to place in include/linux. I think the cleanest approach is to put the register definitions in the driver file, which is the only user, and delete the definition header files in arch/mips/include/... David.