Re: [PATCH v3 08/12] arm64: dts: tegra: Add Tegra186 support
From: Stephen Warren <hidden>
Date: 2016-08-22 17:11:17
Also in:
linux-arm-kernel, linux-tegra
On 08/19/2016 11:32 AM, Thierry Reding wrote:
From: Joseph Lo <redacted> This adds the initial support of Tegra186 SoC. It provides enough to enable the serial console and boot from an initial ramdisk.
quoted hunk
diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
+ uarta: serial@03100000 {
+ compatible = "nvidia,tegra186-uart", "nvidia,tegra20-uart";
+ reg = <0x0 0x03100000 0x0 0x40>;At least in the unit address, I think we want to suppress leading zeroes (s/03100000/3100000/). I'd argue we should do the same in the reg values too, although that makes no difference to the DTB itself. Same comment for other nodes.
+ sysram@30000000 {
+ compatible = "nvidia,tegra186-sysram", "mmio-ram";
+ reg = <0x0 0x30000000 0x0 0x4ffff>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges = <0 0x0 0x0 0x30000000 0x0 0x4ffff>;Shouldn't 0x4ffff be 0x50000 since it's length not max?