Re: [PATCH] Documentation: devicetree: spi: fix wrong spi-bus documentation
From: Mark Rutland <hidden>
Date: 2016-08-03 14:23:43
On Wed, Aug 03, 2016 at 04:11:54PM +0200, Guenther Wutz wrote:
This patch adds missing commas to the spi-bus documentation of the cs-gpio lines. The device tree compiler fails if chip select lines are not comma-separated. Fix the erroneous documentation by adding missing commas. Signed-off-by: Guenther Wutz <redacted> Signed-off-by: Ralf Ramsauer <redacted>
I checked the surrounding context, and this looks correct to me: Acked-by: Mark Rutland <redacted> I assume Rob will pick this up. Mark.
quoted hunk
--- Documentation/devicetree/bindings/spi/spi-bus.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt index 42d5954..3f636f9 100644 --- a/Documentation/devicetree/bindings/spi/spi-bus.txt +++ b/Documentation/devicetree/bindings/spi/spi-bus.txt@@ -31,7 +31,7 @@ with max(cs-gpios > hw cs) So if for example the controller has 2 CS lines, and the cs-gpios property looks like this: -cs-gpios = <&gpio1 0 0> <0> <&gpio1 1 0> <&gpio1 2 0>; +cs-gpios = <&gpio1 0 0>, <0>, <&gpio1 1 0>, <&gpio1 2 0>; Then it should be configured so that num_chipselect = 4 with the following mapping:-- 2.9.2
-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html