Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration
From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-08-31 13:34:36
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-08-31 13:34:36
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
On Wednesday, August 31, 2016 3:07:00 PM CEST Krzysztof Kozlowski wrote:
Ok, sounds reasonable. I want to convert also older platforms S3C (drive strengths and pull up/down differ) and arm64 SoC: Exynos7. For the latter the problem is there is no common place for sharing DTS, except the headers. However this does not really belong to headers. I guess some level of duplication might be still exist.
We have stuff in the headers that belongs way less there, so I wouldn't mind, but having a separate set of definitions for arm64 also isn't a problem at all.
quoted
I think overall, a better solution would have been to define the constants globally (shared with non-exynos) to start with, and have the driver translate generic numbers into vendor specific ones. Obviously it's too late for that now.We could extend driver by adding new bindings accepting generic numbers (and still backward compatible) but this looks like an overkill.
Agreed, that would only make things more confusing, not less. Arnd