On Tue, Aug 30, 2016 at 02:29:45PM -0500, Andrew F. Davis wrote:

On 08/22/2016 08:00 AM, Jens Wiklander wrote:

quoted

+/*
+ * Unprivileged devices in the in the lower half range and privileged

                                ^^ in the in the
[snip]

quoted

+
+	rc = alloc_chrdev_region(&tee_devt, 0, TEE_NUM_DEVICES, "tee");
+	if (rc < 0) {

if (rc) ?

[snip]

quoted

+ * Memory allocated as global shared memory is automatically freed when the
+ * TEE file pointer is closed. The @flags field uses the bits defined by
+ * TEE_SHM_* above. TEE_SHM_MAPPED must currently always be set. If

             ^^^ not really above anymore, out of file now looks like

quoted

+ * TEE_SHM_DMA_BUF global shared memory will be allocated and associated
+ * with a dma-buf handle, else driver private memory.
+ *
+ * @returns a pointer to 'struct tee_shm'

Doesn't say anything, is this really needed?

[snip]

quoted

+/**
+ * struct tee_shm_pool_mem_info - holds information needed to create a shared
+ * memory pool
+ * @vaddr:	Virtual address of start of pool
+ * @paddr:	Physical address of start of pool
+ * @size:	Size in bytes of the pool
+ */
+struct tee_shm_pool_mem_info {
+	unsigned long vaddr;
+	unsigned long paddr;

phys_addr_t paddr; ?

Thanks for taking the time to review this. I'll address all your
comments here in the next version of the patch set.

--
Jens