On Tue, Aug 23, 2016 at 12:58:07PM -0700, Stephen Boyd wrote:

On Fri, Aug 5, 2016 at 2:27 PM, Stephen Boyd [off-list ref] wrote:

quoted

Quoting Peter Chen (2016-07-08 02:04:58)

quoted

On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote:

quoted

@@ -39,6 +42,10 @@ static int ulpi_match(struct device *dev, struct device_driver *driver)
      struct ulpi *ulpi = to_ulpi_dev(dev);
      const struct ulpi_device_id *id;

+     /* Some ULPI devices don't have a product id so rely on OF match */
+     if (ulpi->id.product == 0)
+             return of_driver_match_device(dev, driver);
+

How about using vendor id? It can't be 0, but pid may be 0.
See: http://www.linux-usb.org/usb.ids

Heikki suggested a product id of 0 would mean we need to use DT
matching. Should it be changed to vendor id instead?

Any comments here?

It makes sense. I don't have any problem with that.

Thanks,

-- 
heikki