Re: [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support
From: Moritz Fischer <moritz.fischer@ettus.com>
Date: 2016-08-08 21:12:36
Also in:
linux-arm-kernel, lkml
From: Moritz Fischer <moritz.fischer@ettus.com>
Date: 2016-08-08 21:12:36
Also in:
linux-arm-kernel, lkml
Hi Alan, On Mon, Aug 8, 2016 at 12:18 PM, atull [off-list ref] wrote:
quoted
Please don't use module.h in drivers controlled by a bool Kconfig setting. THanks, Paul.Thanks for the feedback. Can you provide an example of what you would consider to be proper usage in the kernel?
I think Paul is suggesting to use
static int __init alt_fpga_bridge_init(void)
{
platform_driver_register(&alt_fpga_bridge_driver);
}
device_initcall(alt_fpga_bridge_init);
or better:
builtin_platform_driver(&alt_fpga_bridge_driver);
Like for example in: drivers/cpuidle/cpuidle-mvebu-v7.c
Cheers,
Moritz