Re: [Patch v2 3/5] ARM: dts: qcom: msm8974: Add fixed regulator node for vph-pwr-reg
From: Bjorn Andersson <hidden>
Date: 2016-07-28 17:01:47
Also in:
linux-arm-msm
On Mon 18 Jul 22:04 PDT 2016, Bhushan Shah wrote:
quoted hunk ↗ jump to hunk
Cc: Andy Gross <redacted> Cc: Bjorn Andersson <redacted> Cc: David Brown <redacted> Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Russell King <linux@armlinux.org.uk> Cc: linux-arm-msm@vger.kernel.org Cc: linux-soc@vger.kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Bhushan Shah <redacted> --- arch/arm/boot/dts/qcom-msm8974.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi index 570028c..b5e80a4 100644 --- a/arch/arm/boot/dts/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi@@ -615,4 +615,14 @@ regulator-always-on; regulator-boot-on; }; + + vph_pwr_reg: vph-pwr-reg {
Please change this to:
vreg_vph_pwr: vreg-vph-pwr { ...
And you have my
Reviewed-by: Bjorn Andersson <redacted>
+ compatible = "regulator-fixed"; + regulator-name = "vph-pwr";
But this name is good.
+ + regulator-min-microvolt = <3600000>; + regulator-max-microvolt = <3600000>; + + regulator-always-on; + }; };
Regards, Bjorn