Re: [PATCH] ARM: dts: armada388-clearfog: number LAN ports properly

Hi Russell King,
 
 On mer., juil. 27 2016, Russell King - ARM Linux [off-list ref] wrote:

On Wed, Jul 27, 2016 at 12:19:01PM +0200, Gregory CLEMENT wrote:

quoted

Hi,
 
 On ven., juil. 08 2016, Andrew Lunn [off-list ref] wrote:

quoted

On Fri, Jul 08, 2016 at 02:58:39PM +0100, Russell King wrote:

quoted

Currently, the ports as seen from the rear number as:

	eth0 sfp lan5 lan4 lan3 lan2 lan1 lan6

which is illogical - this came about because the rev 2.0 boards have the
LEDs on the front for the DSA switch (lan5-1) reversed.  Rev 2.1 boards
fixed the LED issue, and the Clearfog case numbers the lan ports
increasing from left to right.

Maintaining this illogical numbering causes confusion, with reports that
"my link isn't coming up" and "my connection negotiates 10base-Half"
both of which are due to people thinking that the port next to the SFP
is lan1.

Fix this by renumbering the ports to match people's expectations.

Signed-off-by: Russell King <redacted>

Reviewed-by: Andrew Lunn <redacted>

I missed this patch, but I now applied it on mvebu/dt-4.9

It would be much better to get it into 4.8-rc so that we don't spread
the port renumbering over a large range of kernels, as well as forcing
vendors to carry patches like this to fix problems.

I can move it to the mvebu/fixes branch, it is not too late. Also what
about to apply it on the stable kernel?

Gregory

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html