Re: [PATCH] scripts/dtc: dt_to_config, use full path for dtx_diff

On Mon, Jul 18, 2016 at 9:15 PM, Gaurav Minocha
[off-list ref] wrote:

On Mon, Jul 18, 2016 at 8:00 PM, Gaurav Minocha
[off-list ref] wrote:

quoted

On Mon, Jul 18, 2016 at 7:40 PM, Rob Herring [off-list ref] wrote:

quoted

On Mon, Jul 18, 2016 at 6:12 PM, Frank Rowand [off-list ref] wrote:

quoted

On 07/18/16 15:18, Rob Herring wrote:

quoted

On Fri, Jun 24, 2016 at 7:56 PM, Frank Rowand [off-list ref] wrote:

quoted

From: Frank Rowand <redacted>

Do not require dtx_diff to be in $PATH.

dt_to_config already needs to be run from the root directory of a kernel
tree so use scripts/dtc/dtx_diff instead of dtx_diff.

Okay, now I get a bit further. I get this message even if I set my
.config file on the command line:

grep: ./.config: No such file or directory

All of the following work for me:

  scripts/dtc/dt_to_config --config .config arch/arm/boot/dts/highbank.dts

  scripts/dtc/dt_to_config --config=.config arch/arm/boot/dts/highbank.dts

  scripts/dtc/dt_to_config --config ./.config arch/arm/boot/dts/highbank.dts

  scripts/dtc/dt_to_config --config=./.config arch/arm/boot/dts/highbank.dts

What is the exact command line you are using?

scripts/dtc/dt_to_config -c .build-arm/.config --config-format
arch/arm/boot/dts/highbank.dts

Above command works for me.

My bad, cleaned my local repo. Now, I can see this error. Will get back!

Frank,
It is coming from dtx_diff,
if grep -q "^CONFIG_DTC=y" ${__KBUILD_OUTPUT}/.config ; then

you may have to add a check on .config file here.
if [ -f "${__KBUILD_OUTPUT}/.config" ] && grep -q "^CONFIG_DTC=y"
${__KBUILD_OUTPUT}/.config; then

quoted

quoted

quoted

Just to confirm, you are in the root directory of the kernel source tree
and your .config is in the same directory (since you specified "./.config").

I'm in the root, but .config is not.

Rob

Please let me know if I'm missing something.

--
Gaurav Minocha
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html