Re: [PATCH v2 2/6] libfdt: Add iterator over properties

On Tue, 12 Jul 2016, David Gibson wrote:

On Mon, Jul 11, 2016 at 09:56:19PM +0200, Maxime Ripard wrote:

quoted

+/**
+ * fdt_for_each_property - iterate over all properties of a node
+ * @property_offset:	property offset (int)
+ * @fdt:		FDT blob (const void *)
+ * @node:		node offset (int)
+ *
+ * This is actually a wrapper around a for loop and would be used like so:
+ *
+ *	fdt_for_each_property(fdt, node, property) {

Again, parameter order is out of date.

  also, when did kerneldoc content start specifying data types in the
comment? (int, const void*, ...). i don't think that's standard.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================