Thread (2 messages) 2 messages, 2 authors, 2016-07-08

Re: [PATCH v2 5/7] spi: s3c64xx: add exynos5433 compatible for ioclk handling

From: Andi Shyti <hidden>
Date: 2016-07-08 16:31:58
Also in: linux-arm-kernel, linux-clk, linux-samsung-soc, linux-spi

Hi Mike,
quoted
        pm_runtime_set_autosuspend_delay(&pdev->dev, AUTOSUSPEND_TIMEOUT);
        pm_runtime_use_autosuspend(&pdev->dev);
        pm_runtime_set_active(&pdev->dev);
@@ -1193,6 +1211,8 @@ err_pm_put:
        pm_runtime_disable(&pdev->dev);
        pm_runtime_set_suspended(&pdev->dev);
 
+       clk_disable_unprepare(sdd->ioclk);
+err_disable_src_clk:
        clk_disable_unprepare(sdd->src_clk);
 err_disable_clk:
        clk_disable_unprepare(sdd->clk);
Why aren't these clocks enabled/disabled by calls to pm_runtime_get/put?
yes, they are, but this should be fixed in a different patch.

I will send a follow-up, thanks for pointing this out.

Andi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help