Thread (1 message) 1 message, 1 author, 2016-07-07

Re: [RFC/PATCH] dt: Add of_device_compatible_match()

From: Benjamin Herrenschmidt <hidden>
Date: 2016-07-07 22:25:52

On Thu, 2016-07-07 at 09:42 -0700, Frank Rowand wrote:
of_device_is_compatible() returns a higher value for a better match.

of_fdt_match() returns a lower value for a better match.
Ugh ... that smells of trainwreck...
So checking for (tmp < score) will give you the opposite of what you want.
Yup. I'll fix it.
And if you are replacing of_fdt_match() with of_device_compatible_match(),
the caller will have the expectation that a smaller score is a better
match.
The few callers I converted only really cared about exact matches.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help