Thread (8 messages) 8 messages, 3 authors, 2016-08-15

Re: [PATCH v4] ARM: dts: sun8i: Add dts file for Olimex A33-OLinuXino

From: Maxime Ripard <hidden>
Date: 2016-07-27 06:21:56
Also in: linux-arm-kernel, lkml

On Wed, Jul 27, 2016 at 08:12:29AM +0300, stefan.mavrodiev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
quoted
quoted
+&reg_dcdc1 {
+	regulator-always-on;
+	regulator-min-microvolt = <3300000>;
+	regulator-max-microvolt = <3300000>;
+	regulator-name = "vcc-dsi";
+};
What is it used for? Is it really necessary to keep it on at all time?
I think so.
This is the supply for the MMC.
Then it's poorly named, and you should tie it to the MMC, and remove
the always-on if it's only used by the mmc. always-on is supposed to
be for regulators that shouldn't but turned off for the system to stay
running. Some MMC regulator doesn't fit that description.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help