Re: [PATCH v11 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl
From: Scott Wood <hidden>
Date: 2016-07-21 16:45:40
Also in:
linux-mmc, linuxppc-dev, lkml
On Thu, 2016-07-21 at 20:26 +1000, Michael Ellerman wrote:
Quoting Scott Wood (2016-07-21 04:31:48)quoted
On Wed, 2016-07-20 at 13:24 +0200, Arnd Bergmann wrote:quoted
On Saturday, July 16, 2016 9:50:21 PM CEST Scott Wood wrote:quoted
From: yangbo lu <redacted> Move mpc85xx.h to include/linux/fsl and rename it to svr.h as a common header file. This SVR numberspace is used on some ARM chips as well as PPC, and even to check for a PPC SVR multi-arch drivers would otherwise need to ifdef the header inclusion and all references to the SVR symbols. Signed-off-by: Yangbo Lu <redacted> Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> Acked-by: Stephen Boyd <redacted> Acked-by: Joerg Roedel <redacted> [scottwood: update description] Signed-off-by: Scott Wood <redacted>As discussed before, please don't introduce yet another vendor specific way to match a SoC ID from a device driver. I've posted a patch for an extension to the soc_device infrastructure to allow comparing the running SoC to a table of devices, use that instead.As I asked before, in which relevant maintainership capacity are you NACKing this?I'll nack the powerpc part until you guys can agree.
OK, I've pulled these patches out. For the MMC issue I suggest using ifdef CONFIG_PPC and mfspr(SPRN_SVR) like the clock driver does[1] and we can revisit the issue if/when we need to do something similar on an ARM chip. -Scott [1] One of the issues with Arnd's approach is that it wouldn't have worked for early things like the clock driver, and he didn't seem to mind using ifdef and mfspr() there. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html