Thread (4 messages) 4 messages, 3 authors, 2016-07-18

Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property

From: Sören Brinkmann <hidden>
Date: 2016-07-17 16:11:56
Also in: linux-arm-kernel, linux-clk, lkml

On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote:
The "clock-output-names" property is useful for generic clock
providers such as fixed-clock, fixed-factor-clock, etc.

On the other hand, it should not be used for really SoC-specific
clock providers like this one.  As you see in "enum zynq_clk" in
this driver, it is written as if it already knows all the clock
names.  Besides, this is instantiated only once, so no clock name
conflict would happen even if the clock names are hard-coded in the
driver.

The device tree (arch/arm/boot/dts/zynq-7000.dtsi) will be fixed
later.

Signed-off-by: Masahiro Yamada <redacted>
IIRC, this was the only way to allow circular clock routing. E.g. there
are use-cases that route an FCLK back into the PS to use it as input for
the GEM. With the introduction of deferred probing this might all be
possible now but it would be good to verify that this kind of circular
clock routing still works with this change.

	Sören
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help