Re: [PATCH 1/3] Revert "drivers/rtc/rtc-s3c.c: add .needs_src_clk to s3c6410 RTC data"
From: Krzysztof Kozlowski <hidden>
Date: 2016-07-11 05:48:37
Also in:
linux-arm-kernel, linux-rtc, linux-samsung-soc, lkml
On 07/09/2016 11:23 AM, Randy Li wrote:
This reverts commit 8792f7772f4f40ffc68bad5f28311205584b734d. The s3c6410 rtc don't use rtc_src property, that property is designed for Exynos5250 and Exynos5440. The problem reported in the commit I mentioned should be fixed in the other way.
... so you break in this commit all the newer platforms because the rtc_src clock won't be enabled. Does not look right. Best regards, Krzysztof
quoted hunk ↗ jump to hunk
Signed-off-by: Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org> --- drivers/rtc/rtc-s3c.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index d01ad7e..5dc18ca 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c@@ -801,7 +801,6 @@ static struct s3c_rtc_data const s3c2443_rtc_data = { static struct s3c_rtc_data const s3c6410_rtc_data = { .max_user_freq = 32768, - .needs_src_clk = true, .irq_handler = s3c6410_rtc_irq, .set_freq = s3c6410_rtc_setfreq, .enable_tick = s3c6410_rtc_enable_tick,
-- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.