Re: [PATCH 1/2] input: adc-keys: add DT binding documentation

On Sun, Jul 03, 2016 at 02:43:56PM +0100, Jonathan Cameron wrote:

On 01/07/16 22:30, Alexandre Belloni wrote:

quoted

Add documentation for ADC keys

Signed-off-by: Alexandre Belloni <redacted>

Clean looking binding to me - one comment inline.

Jonathan

quoted

---
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org

 .../devicetree/bindings/input/adc-keys.txt         | 45 ++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt

diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt
new file mode 100644
index 000000000000..873476bb4eab
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/adc-keys.txt

@@ -0,0 +1,45 @@
+Allwinner sun4i low res adc attached tablet keys

What is allwinner specific in here?  Looks pretty general purpose to me!

quoted

+------------------------------------------------
+
+Required properties:
+ - compatible: "adc-keys"
+ - io-channels: Phandle to an ADC channel
+ - io-channel-names = "buttons";
+ - voltage-keyup-mvolt: Voltage at which all the keys are considered up.
+
+Each key is represented as a sub-node of "adc-keys":
+
+Required subnode-properties:
+	- label: Descriptive name of the key.
+	- linux,code: Keycode to emit.
+	- voltage-mvolt: Voltage adc input when this key is pressed.

voltage-mcvoltface?

"voltage" is redundant and use standard units. How about 
{press,up}-threshold-microvolt?

Rob