Re: [PATCH 2/4] spi: Document option to wake a device by toggling CS

From
Doug Anderson <hidden>
Date
2016-07-01 04:32:10
Also in
linux-spi, lkml
Reply to
Geert Uytterhoeven, 2016-06-30
Hi,

On Thu, Jun 30, 2016 at 12:12 AM, Geert Uytterhoeven
[off-list ref] wrote:
CC devicetree
And Rob and Mark...

 ./scripts/get_maintainer.pl -f
Documentation/devicetree/bindings/spi/spi-bus.txt

Mark Brown [off-list ref] (maintainer:SPI SUBSYSTEM)
Rob Herring [off-list ref] (maintainer:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS)
Mark Rutland [off-list ref] (maintainer:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS)
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:SPI SUBSYSTEM)
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list:OPEN FIRMWARE AND FLATTENED
DEVICE TREE BINDINGS)
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org (open list)

On Thu, Jun 30, 2016 at 5:54 AM,  [off-list ref] wrote:
quoted
From: Andrey Pronin <redacted>

Some SPI devices may go to sleep after a period of inactivity
on SPI. For such devices, if enough time has passed since the
last SPI transaction, toggle CS and wait for the device to
start before communicating with it.

Signed-off-by: Andrey Pronin <redacted>
---
 Documentation/devicetree/bindings/spi/spi-bus.txt | 7 +++++++
 1 file changed, 7 insertions(+)
Overall note is that devicetree bindings patches should be _before_
the code that uses them, so you should swap patch #1 and patch #2.
quoted
diff --git a/Documentation/devicetree/bindings/spi/spi-bus.txt b/Documentation/devicetree/bindings/spi/spi-bus.txt
index 42d5954..1b7ffd4 100644
--- a/Documentation/devicetree/bindings/spi/spi-bus.txt
+++ b/Documentation/devicetree/bindings/spi/spi-bus.txt
@@ -63,6 +63,13 @@ contain the following properties.
                       used for MISO. Defaults to 1 if not present.
 - spi-rx-delay-us  - (optional) Microsecond delay after a read transfer.
 - spi-tx-delay-us  - (optional) Microsecond delay after a write transfer.
+- cs-wake-after-sleep - (optional) Device may go to sleep after a period
+               of SPI inactivity. If this flag is set, toggle CS and
+               wait for it to wake before communicating to it.
You probably also need a property for how long it needs to be asserted
when you "toggle" it?
quoted
+- cs-sleep-delay  - (optional) Delay after which the device may go to
+               sleep if there was no SPI activity (msec).
+- cs-wake-duration - (optional) Time it takes the device to wake up after
+               toggling CS if it went to sleep (msec).
I believe that from your code the second two properties are both
required if the first property is set.  That should be in the
bindings.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thread (2 messages) 2 messages, 2 authors, last reply 2016-07-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help