Re: Re: [PATCH 1/4] brcmfmac: Add brcm,nvram_file_name dt property

From
Julian Calaby <hidden>
Date
2016-06-30 09:33:36
Hi Kalle,

On 30 Jun 2016 6:46 p.m., "Kalle Valo" [off-list ref] wrote:
Arend Van Spriel [off-list ref] writes:
quoted
quoted
Since we are dealing with a per-board config-file here, which is
loaded from the os filesystem we really need to specify a basename
here as the list of possible boards is endless, so we cannot
have a lookup table in the driver.
As Jonas mentioned the general principle of device tree is to be
agnostic with regards to OS and/or driver as you undoubtedly know. His
proposal seems like a usable solution for your problem while complying
to the device tree principle. So instead of overriding the default
brcmfmac should modify it when dt specifies the "module" property, ie:

no "module" in DT:    nvram filename = brcm/brcmfmac43362-sdio.txt
"module=ap6210" in DT:        nvram filename =
brcm/brcmfmac43362-ap6210.txt
Just out of curiosity, what does "ap6210" exactly mean? I get that 43362
is the chip id, but not ap6210. Is it just an arbitrary name?
Ap6210 is a chip that contains a 43362 and probably some Bluetooth chip
also.

Thanks,

Julian Calaby

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
Thread (1 message) 1 message, 1 author, last reply 2016-06-30
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help