Re: [PATCH] of: fix reference counting in of_graph_get_endpoint_by_regs
From: Rob Herring <hidden>
Date: 2016-06-22 21:01:02
On Fri, Jun 17, 2016 at 5:05 AM, Lucas Stach [off-list ref] wrote:
quoted hunk
The called of_graph_get_next_endpoint() already decrements the refcount of the prev node, so it is wrong to do it again in the calling function. Fixes: 8ccd0d0ca041 (of: add helper for getting endpoint node of specific identifiers) Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Reported-by: David Jander <david-/Q/L1SwJa3aEVqv0pETR8A@public.gmane.org> Signed-off-by: Lucas Stach <redacted> --- drivers/of/base.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/of/base.c b/drivers/of/base.c index ebf84e3b56d5..6d8514c431f5 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c@@ -2310,7 +2310,6 @@ struct device_node *of_graph_get_endpoint_by_regs( while (1) { node = of_graph_get_next_endpoint(parent, prev_node); - of_node_put(prev_node); if (!node) break;
Can you convert this to use for_each_endpoint_of_node instead? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html