Thread (8 messages) 8 messages, 4 authors, 2016-06-20

Re: [PATCH] [v5] net: emac: emac gigabit ethernet controller driver

From: David Miller <davem@davemloft.net>
Date: 2016-06-16 04:41:42
Also in: linux-arm-msm, netdev

From: Timur Tabi <redacted>
Date: Tue, 14 Jun 2016 17:22:35 -0500
+/* Free all descriptors of given receive queue */
+static void emac_rx_q_free_descs(struct emac_adapter *adpt)
+{
+	struct emac_rx_queue *rx_q = &adpt->rx_q;
+	struct device *dev = adpt->netdev->dev.parent;
+	size_t size;
+	int i;
Please always order local variable declarations from longest to shortest
line.

Audit your entire driver for this issue, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help