Re: [PATCH v4] USB: Fix of_usb_get_dr_mode_by_phy with a shared phy block

Hi,

On Fri, Jun 10, 2016 at 08:27:03PM +0200, Hans de Goede wrote:

Hi,

On 10-06-16 17:00, Bin Liu wrote:

quoted

Hi,

On Fri, Jun 10, 2016 at 11:46:25AM +0200, Hans de Goede wrote:

quoted

Some SoCs have a single phy-hw-block with multiple phys, this is
modelled by a single phy dts node, so we end up with multiple
controller nodes with a phys property pointing to the phy-node
of the otg-phy.

Only one of these controllers typically is an otg controller, yet we
were checking the first controller who uses a phy from the block and
then end up looking for a dr_mode property in e.g. the ehci controller.

This commit fixes this by adding an arg0 parameter to
of_usb_get_dr_mode_by_phy and make of_usb_get_dr_mode_by_phy
check that this matches the phandle args[0] value when looking for
the otg controller.

Signed-off-by: Hans de Goede <redacted>
---
Changes in v2:
-Add a arg0 parameter instead of looking for nodes with a dr_mode property
Changes in v3:
-No changes
Changes in v4:
-When arg0 == -1, use of_parse_phandle instead of of_parse_phandle_with_args
because using of_parse_phandle_with_args breaks phy's which use the usb-phy
bindings instead of the generic phy bindings

I would think you'd better send this patch with --in-reply-to to the
patch in v3, so whoever picks it can easily pick the whole patch set,
especially in this case the set touches multiple modules, and you don't
want to resend the other patches.

Does that mean that you're happy with this patch now ? If so can I have
your Acked-by please ? Then I'll resend the entire set after that.

Yes, the patch looks good to me, but I am not sure I should 'Acked-by'
since I am not the maintainer of it.

BTY, since we are here, please change the patch 4/4 subject prefix to
'usb: musb: sunxi: ...' when you resend, I noticed it after I Acked-by.

Regards,
-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html