Re: [PATCH v2 2/4] ARM: dts: imx6q: extend support for the cm-fx6

Hi Fabio,

Thanks for your review!

On 06/05/2016 09:14 PM, Fabio Estevam wrote:

On Sun, Jun 5, 2016 at 3:26 PM,  [off-list ref] wrote:

quoted

+&pcie {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_pcie>;
+       reset-gpio = <&gpio1 26 GPIO_ACTIVE_HIGH>;

I suppose this should be active low, right?

hmm, the vendor devicetree uses active high but does not set
reset-gpio-active-high. In a quick test it turned out that setting this
property keeps the pci bus in reset.
In fact, the linux driver ignores the polarity and falls back to active
low. This explains why specifying active high "worked" here...

So you are right and it should be active low. I'll fix that.

With this fixed:

Reviewed-by: Fabio Estevam <redacted>

Thanks,
Christopher
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html