Re: [PATCH V6 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga
From: David Miller <hidden>
Date: 2016-06-30 12:35:07
Also in:
lkml, netdev
From: <redacted> Date: Wed, 29 Jun 2016 02:10:13 -0700
+static void auto_nego_timer_callback(unsigned long data)
+{
+ u16 val = 0;
+ u16 speed = 0;
+ u16 duplex = 0;
+
+ struct tse_pcs *pcs = (struct tse_pcs *)data;
+ void __iomem *tse_pcs_base = pcs->tse_pcs_base;
+ void __iomem *sgmii_adapter_base = pcs->sgmii_adapter_base;Please do not break up a set of local variable declarations with an empty line.
+ if ((tse_pcs_base) && (sgmii_adapter_base))
Unnecessary parenthesis.
+ if ((tse_pcs_base) && (sgmii_adapter_base))
Likewise.
quoted hunk ↗ jump to hunk
@@ -88,9 +104,13 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device * struct device_node *np = dev->of_node; struct regmap *sys_mgr_base_addr; u32 reg_offset, reg_shift; - int ret; - struct device_node *np_splitter; + int ret, index; + struct device_node *np_splitter = NULL; + struct device_node *np_sgmii_adapter = NULL; + struct resource res_splitter; + struct resource res_tse_pcs; + struct resource res_sgmii_adapter;
Again, do not break up local variable declarations with an empty line like this. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html