Thread (10 messages) 10 messages, 4 authors, 2016-06-26

Re: [PATCH v4 0/2] ASoC: da7219: Convert driver to use generic FW functions

From: Opensource [Adam Thomson] <hidden>
Date: 2016-06-21 23:18:41
Also in: alsa-devel, linux-acpi, lkml

On 21 June 2016 23:30, Rafael J. Wysocki wrote:
quoted
This patch set converts the da7219 codec driver to use device/fwnode functions
to access properties, instead of the DT only of_* functions, allowing ACPI
to be used as well.

The DT bindings for da7219 have a device node for the main codec properties,
and a named child node (da7219_aad), which contains all of the accessory
detection related properties for the device. ACPI also supports this kind of
FW hierarchy (data only sub-nodes), but some support in the kernel needs to be
added to take make use of this in driver code.

The first patch adds functions to allow searching for a named child node of a
device, for both DT and ACPI, and the second patch updates the codec driver to
use the standard device/fwnode calls, including this new function.

These changes are based on the v4.7-rc4 kernel.

Changes in v4:
  - Rebase to v4.7-rc4
  - Use strcmp() in acpi_data_node_match() for matching ACPI data nodes.

Changes in v3:
  - Use of_node_cmp() in device_get_named_child_node() to match DT node.

Changes in v2:
  - Rebase to v4.7-rc1
  - Small updates to codec patch based on previous reviewer comments

Adam Thomson (2):
   device property: Add function to search for named child of device
   ASoC: da7219: Convert driver to use generic device/fwnode functions

  drivers/base/property.c       |  28 ++++++++++++
  include/acpi/acpi_bus.h       |   7 +++
  include/linux/acpi.h          |   6 +++
  include/linux/of.h            |  14 +++---
  include/linux/property.h      |   3 ++
  sound/soc/codecs/da7219-aad.c | 103 +++++++++++++++++++++--------------------
-
quoted
  sound/soc/codecs/da7219.c     |  34 +++++++-------
  7 files changed, 119 insertions(+), 76 deletions(-)

--
1.9.3
I'm fine with the first patch and the second one carries a couple of
ACKs already, so do you want me to apply them both?
Thanks Rafael. I think we still need Mark's Ack for the ASoC codec changes
though before we can proceed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help