Re: [PATCH V4 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga
From: Arnd Bergmann <arnd@arndb.de>
Date: 2016-06-21 09:33:35
Also in:
lkml, netdev
On Tuesday, June 21, 2016 1:46:11 AM CEST thloh@altera.com wrote:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt index 72d82d6..dd10f2f 100644 --- a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt +++ b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt@@ -17,9 +17,26 @@ Required properties: Optional properties: altr,emac-splitter: Should be the phandle to the emac splitter soft IP node if DWMAC controller is connected emac splitter. +phy-mode: The phy mode the ethernet operates in +altr,sgmii_to_sgmii_converter: phandle to the TSE SGMII converter +
Please use '-' instead of '_' in the property names. Can you explain in the patch description why you can't reference the converter using the normal "phy-handle" property and implement the converter as a phy driver? Arnd