RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

-----Original Message-----
From: Ferre, Nicolas
Sent: 2016年6月8日 18:46
To: Yang, Wenyou <redacted>; Alan Stern
[off-list ref]; Greg Kroah-Hartman
[off-list ref]; Rob Herring [off-list ref]; Alexandre
Belloni [off-list ref]
Cc: Pawel Moll <redacted>; Mark Brown <broonie@kernel.org>; Ian
Campbell [off-list ref]; Kumar Gala [off-list ref];
linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB
suspend

Le 08/06/2016 12:04, Nicolas Ferre a écrit :

quoted

Le 08/06/2016 06:15, Wenyou Yang a écrit :

quoted

In order to the save power consumption, as a workaround, suspend
forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI
Interrupt Configuration Register in the SFRs while OHCI USB suspend.

This suspend operation must be done before the USB clock is disabled,
resume after the USB clock is enabled.

Signed-off-by: Wenyou Yang <redacted>

Little nitpicking below...

quoted

---

Changes in v3:
 - Change the compatible description for more precise.

Changes in v2:
 - Add compatible to support forcibly suspend the ports.
 - Add soc/at91/at91_sfr.h to accommodate the defines.
 - Add error checking for .sfr_regmap.
 - Remove unnecessary regmap_read() statement.

 .../devicetree/bindings/usb/atmel-usb.txt          |  6 +-
 drivers/usb/host/ohci-at91.c                       | 80 +++++++++++++++++++++-
 include/soc/at91/at91_sfr.h                        | 29 ++++++++

Oops sorry, additional comment which is not nitpicking, this one:

We already have SFR header file in this patch:

Author: Cyrille Pitchen [off-list ref]
Date:   Thu Mar 17 17:04:00 2016 +0100

    ARM: dts: at91: sama5d2: add SFR node

    This SFR node is looked up by the I2S controller driver to tune the
    SFR_I2SCLKSEL register.

    Signed-off-by: Cyrille Pitchen [off-list ref]
    Signed-off-by: Ludovic Desroches [off-list ref]
    Acked-by: Alexandre Belloni [off-list ref]
    Acked-by: Rob Herring [off-list ref]
    Signed-off-by: Nicolas Ferre [off-list ref]

Which is already accepted by arm-soc guys for 4.7... So my ack transforms into a
nack, sorry...

We will have to coordinate the effort and maybe take the whole series with us. But
for sure, you'll have to use the existing include/soc/at91/atmel-sfr.h file and build
on top of it...

Sorry, not notice this file.

I will built it on this file.

Bye,

quoted

quoted

 3 files changed, 112 insertions(+), 3 deletions(-)  create mode
100644 include/soc/at91/at91_sfr.h

[..]

quoted

But you can take my:

Acked-by: Nicolas Ferre <redacted>

with the little corrections listed.

Alan, We plan to take the second patch of this series with AT91 git
tree through arm-soc. Do you agree to take this one through yours?

Alan, forget this request, we'll have to coordinate differently.

Sorry for the noise. Bye,
--
Nicolas Ferre

Best Regards,
Wenyou Yang
㈤旃�
�&�~�&���+-遍荻��w����笔�m�^�'
斗��{ay�
�����,j��f＂�h��祸�/oSc��诔9�u捆驽��&jwó(�����茛j"���m����赇z罐��帼f＂�h���~�m�