Hi!

quoted

Not V4L2_CID_USER_AD5820...?

The rest of the controls have no USER as part of the macro name, so I
wouldn't use it here either.

Ok.

quoted

Ok, separate header file for 2 lines seemed like a bit of overkill,
but why not.

That follows an existing pattern of how controls have been implemented in
other drivers.

Ok.

Could you merge this with the driver patch? I've dropped that from my ad5820
branch as it does not compile.

Yes, merged patch should be in your inbox now.

Thanks,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html