Re: [PATCH V2 1/4] clk: max77686: Combine Maxim max77686 and max77802 driver
From: Krzysztof Kozlowski <hidden>
Date: 2016-06-17 06:02:05
Also in:
linux-arm-kernel, linux-clk, linux-samsung-soc, lkml
On 06/16/2016 03:23 PM, Laxman Dewangan wrote:
The clock IP used on the Maxim PMICs max77686 and max77802 are same. The configuration of clock register is also same except the number of clocks. Part of common code utilisation, there is 3 files for these chips clock driver, one for common and two files for driver registration. Combine both drivers into single file and move common code into same common file reduces the 2 files and make max77686 and max77802 clock driver in single fine. This driver does not depends on the parent driver structure. The regmap handle is acquired through regmap APIs for the register access. This combination of driver helps on adding clock driver for different Maxim PMICs which has similar clock IP like MAX77620 and MAX20024. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> CC: Krzysztof Kozlowski <redacted> CC: Javier Martinez Canillas <javier@dowhile0.org> Reviewed-by: Javier Martinez Canillas <redacted> Tested-by: Javier Martinez Canillas <redacted> Tested-by: Krzysztof Kozlowski <redacted> --- Changes from V1: - Collected RB and TB from Javier. - Change the max_gen to max77686. - Rename structure and avoid duplication for reg and mask. - Taken care of comment from Krzysztof on coding. --- drivers/clk/Kconfig | 15 +-- drivers/clk/Makefile | 2 - drivers/clk/clk-max-gen.c | 194 ----------------------------------- drivers/clk/clk-max-gen.h | 32 ------ drivers/clk/clk-max77686.c | 244 ++++++++++++++++++++++++++++++++++++++++++--- drivers/clk/clk-max77802.c | 96 ------------------ 6 files changed, 234 insertions(+), 349 deletions(-) delete mode 100644 drivers/clk/clk-max-gen.c delete mode 100644 drivers/clk/clk-max-gen.h delete mode 100644 drivers/clk/clk-max77802.c
Reviewed-by: Krzysztof Kozlowski <redacted> Best regards, Krzysztof